Remove amount issued check from database that is responsibility of the mint #1066

Closed
opened 2025-09-11 10:25:23 +00:00 by thesimplekid · 2 comments
thesimplekid commented 2025-09-11 10:25:23 +00:00 (Migrated from github.com)

It was brought up in the dev call that while this is a light weight check, it is not the responsibility of the storage layer to do checks like this and it should be done in the mint. It currently is done in the mint and this is a redundant check that should be removed.

github.com/cashubtc/cdk@f2f5425395/crates/cdk-sql-common/src/mint/mod.rs (L693-L716)

cc @asmogo @crodas

It was brought up in the dev call that while this is a light weight check, it is not the responsibility of the storage layer to do checks like this and it should be done in the mint. It currently is done in the mint and this is a redundant check that should be removed. https://github.com/cashubtc/cdk/blob/f2f54253958fb93f715cca12da7ce303bf9efb64/crates/cdk-sql-common/src/mint/mod.rs#L693-L716 cc @asmogo @crodas
github-actions[bot] commented 2025-11-22 02:44:30 +00:00 (Migrated from github.com)

This issue is stale because it has been open for 60 days with no activity.

This issue is stale because it has been open for 60 days with no activity.
crodas commented 2026-01-12 19:50:12 +00:00 (Migrated from github.com)

Fixed in 1446 already

Fixed in 1446 already
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cashubtc/cdk#1066
No description provided.