cashubtc/cdk

Fork 0

rename ln settings in toml configuration #1127

Closed

asmogo wants to merge 21 commits from config/refactor into main

asmogo commented

2025-09-25 22:31:36 +00:00

(Migrated from github.com)

Description

Replace Ln/LnBackend with Backend/BackendType across mintd
Move settings.ln.ln_backend to settings.backend.name
Update example config: [ln] -> [backend], ln_backend -> name
Adjust env var mapping and internal references accordingly
Add serde aliases for fake_wallet and grpc_processor
Update integration tests to the new settings schema

BREAKING CHANGE: rename config table and key:

[ln] -> [payment_backend]
ln_backend -> kind

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Checklist

I followed the code style guidelines
I ran just final-check before committing

### Description - Replace Ln/LnBackend with Backend/BackendType across mintd - Move settings.ln.ln_backend to settings.backend.name - Update example config: [ln] -> [backend], ln_backend -> name - Adjust env var mapping and internal references accordingly - Add serde aliases for fake_wallet and grpc_processor - Update integration tests to the new settings schema BREAKING CHANGE: rename config table and key: - [ln] -> [payment_backend] - ln_backend -> kind  ----- ### Notes to the reviewers  ----- ### Suggested [CHANGELOG](https://github.com/cashubtc/cdk/blob/main/CHANGELOG.md) Updates  #### CHANGED #### ADDED #### REMOVED #### FIXED ---- ### Checklist * [ ] I followed the [code style guidelines](https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md) * [ ] I ran `just final-check` before committing

thesimplekid (Migrated from github.com) reviewed

2025-09-29 10:13:16 +00:00

crates/cdk-mintd/example.config.toml

Should it be payment_backend. Just backend could mean database or something?

kind = "fakewallet"

Is kind better?

```suggestion kind = "fakewallet" ``` Is kind better?

asmogo (Migrated from github.com) reviewed

2025-09-29 15:04:06 +00:00

crates/cdk-mintd/example.config.toml

yes. I like that.

asmogo commented

2025-09-29 15:05:39 +00:00

(Migrated from github.com)

should we do prefixes to the payment_backends? like
[payment_backend.cln] instead of [cln].

This would be consistent with the database configuration.

should we do prefixes to the payment_backends? like `[payment_backend.cln]` instead of `[cln]`. This would be consistent with the database configuration.

thesimplekid commented

2025-09-29 16:16:48 +00:00

(Migrated from github.com)

should we do prefixes to the payment_backends? like [payment_backend.cln] instead of [cln].

This would be consistent with the database configuration.

Yes I think this is better

> should we do prefixes to the payment_backends? like `[payment_backend.cln]` instead of `[cln]`. > > This would be consistent with the database configuration. Yes I think this is better

👍 1

asmogo commented

2025-12-10 21:28:04 +00:00

(Migrated from github.com)

I have updated this to be backwards compatible with the old config https://github.com/cashubtc/cdk/pull/1127/commits/60037e7f2e5e53349f49505df871fef5d237b5cd

We print deprecation warnings to std out if we see the old [ln] configuration is still active.

I have updated this to be backwards compatible with the old config https://github.com/cashubtc/cdk/pull/1127/commits/60037e7f2e5e53349f49505df871fef5d237b5cd We print deprecation warnings to std out if we see the old [ln] configuration is still active.

thesimplekid commented

2025-12-15 14:23:31 +00:00

(Migrated from github.com)

Tried this with my existing config and worked and got the expected warning. Is there anything else you have left here or think its good?

ACK b00c944100

This does not rename anything that gets added to the db so we don't have to migrate anything there.

Tried this with my existing config and worked and got the expected warning. Is there anything else you have left here or think its good? ACK b00c944100854b2103ad2940a5a10f080fa58763 This does not rename anything that gets added to the db so we don't have to migrate anything there.

github-actions[bot] commented

2026-02-14 03:39:11 +00:00

(Migrated from github.com)

This PR is stale because it has been open for 60 days with no activity.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cashubtc/cdk!1127

No description provided.

Rows
Columns