cashubtc/cdk

Fork 0

Fix bug with websocket close #1144

Merged

crodas merged 2 commits from fix/close-ws-close into main

2025-10-02 09:12:18 +00:00

crodas commented

2025-09-30 23:20:13 +00:00

(Migrated from github.com)

Description

Fixes #1111

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Checklist

I followed the code style guidelines
I ran just final-check before committing

### Description Fixes #1111 ----- ### Notes to the reviewers  ----- ### Suggested [CHANGELOG](https://github.com/cashubtc/cdk/blob/main/CHANGELOG.md) Updates  #### CHANGED #### ADDED #### REMOVED #### FIXED ---- ### Checklist * [ ] I followed the [code style guidelines](https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md) * [ ] I ran `just final-check` before committing

thesimplekid commented

2025-10-01 09:08:27 +00:00

(Migrated from github.com)

Does the wallet send a close frame when it is done with a connection or does it just drop?

crodas commented

2025-10-01 09:21:12 +00:00

(Migrated from github.com)

@thesimplekid it used to just drop it. This Pr sends a closing frame and then drops the connection

thesimplekid commented

2025-10-01 10:10:28 +00:00

(Migrated from github.com)

Maybe I'm just missing context but this seems to only send a close frame on an error case? Why is there an error case if we're just done with a subscription?

thesimplekid commented

2025-10-01 12:15:04 +00:00

(Migrated from github.com)

ACK 8a0369076e

ACK 8a0369076e99000012f8351f416c84a000217857

thesimplekid (Migrated from github.com) approved these changes

2025-10-02 09:12:09 +00:00

github-actions[bot] commented

2025-10-28 12:59:06 +00:00

(Migrated from github.com)

Backport failed for v0.13.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin v0.13.x
git worktree add -d .worktree/backport-1144-to-v0.13.x origin/v0.13.x
cd .worktree/backport-1144-to-v0.13.x
git switch --create backport-1144-to-v0.13.x
git cherry-pick -x 81a47d5d12f99b1c2fa64698f28aacbff4f93471

Backport failed for `v0.13.x`, because it was unable to cherry-pick the commit(s). Please cherry-pick the changes locally and resolve any conflicts. ```bash git fetch origin v0.13.x git worktree add -d .worktree/backport-1144-to-v0.13.x origin/v0.13.x cd .worktree/backport-1144-to-v0.13.x git switch --create backport-1144-to-v0.13.x git cherry-pick -x 81a47d5d12f99b1c2fa64698f28aacbff4f93471 ```

No reviewers

thesimplekid

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cashubtc/cdk!1144

No description provided.

Rows
Columns