Make sorting Transactions a stable sort #1147

Merged

benthecarman merged 1 commit from stable-sort into main

2025-10-02 09:11:47 +00:00

benthecarman commented

2025-10-01 15:03:49 +00:00

(Migrated from github.com)

Description

If you had 2 Transactions that had the same timestamp the sort could be unstable and could cause annoying issues. Now it will compare the ids if they are equal and should always have a stable sorting implementation now.

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Sorting Transactions is now more stable

Checklist

I followed the code style guidelines
I ran just final-check before committing

### Description  If you had 2 Transactions that had the same timestamp the sort could be unstable and could cause annoying issues. Now it will compare the ids if they are equal and should always have a stable sorting implementation now. ### Notes to the reviewers  ----- ### Suggested [CHANGELOG](https://github.com/cashubtc/cdk/blob/main/CHANGELOG.md) Updates  #### CHANGED #### ADDED #### REMOVED #### FIXED Sorting `Transaction`s is now more stable ---- ### Checklist * [ ] I followed the [code style guidelines](https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md) * [ ] I ran `just final-check` before committing

davidcaseria (Migrated from github.com) approved these changes

2025-10-01 16:41:22 +00:00

thesimplekid (Migrated from github.com) approved these changes

2025-10-02 09:11:40 +00:00

thesimplekid (Migrated from github.com) left a comment

Thanks