Split mint mod.rs into separate trait modules #1490

2026-01-04T03:21:51Z

crodas commented

2026-01-04 03:21:51 +00:00

(Migrated from github.com)

Description

Split the large monolithic mod.rs file into separate files, each containing a database trait and its corresponding transaction trait:

proofs.rs: MintProofsTransaction + MintProofsDatabase
keys.rs: MintKeyDatabaseTransaction + MintKeysDatabase
quotes.rs: MintQuotesTransaction + MintQuotesDatabase
signatures.rs: MintSignatureTransaction + MintSignaturesDatabase
keyvalue.rs: KVStoreTransaction + KVStoreDatabase + KVStore
saga.rs: SagaTransaction + SagaDatabase
completed_operations.rs: CompletedOperationsTransaction + CompletedOperationsDatabase

The mod.rs now only contains struct definitions, migrations, and the main MintDatabase/MintTransaction/DbTransactionFinalizer impls.

closes: https://github.com/cashubtc/cdk/issues/1489

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Checklist

I followed the code style guidelines
I ran just final-check before committing

### Description Split the large monolithic mod.rs file into separate files, each containing a database trait and its corresponding transaction trait: - proofs.rs: MintProofsTransaction + MintProofsDatabase - keys.rs: MintKeyDatabaseTransaction + MintKeysDatabase - quotes.rs: MintQuotesTransaction + MintQuotesDatabase - signatures.rs: MintSignatureTransaction + MintSignaturesDatabase - keyvalue.rs: KVStoreTransaction + KVStoreDatabase + KVStore - saga.rs: SagaTransaction + SagaDatabase - completed_operations.rs: CompletedOperationsTransaction + CompletedOperationsDatabase The mod.rs now only contains struct definitions, migrations, and the main MintDatabase/MintTransaction/DbTransactionFinalizer impls. closes: https://github.com/cashubtc/cdk/issues/1489 ----- ### Notes to the reviewers  ----- ### Suggested [CHANGELOG](https://github.com/cashubtc/cdk/blob/main/CHANGELOG.md) Updates  #### CHANGED #### ADDED #### REMOVED #### FIXED ---- ### Checklist * [x] I followed the [code style guidelines](https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md) * [x] I ran `just final-check` before committing

thesimplekid (Migrated from github.com) reviewed

2026-01-04 09:38:35 +00:00

crates/cdk-sql-common/src/mint/proofs.rs

					
				@ -0,0 +1,500 @@

				//! Proofs database implementation

I think we should remove the inline.

Inline is best for small cpu bound tasks, this is async and has io.

I think we should remove the inline. Inline is best for small cpu bound tasks, this is async and has io. ```suggestion ```

crates/cdk-sql-common/src/mint/quotes.rs

					
				@ -0,0 +1,1133 @@

				//! Quotes database implementation

```suggestion ```

thesimplekid (Migrated from github.com) approved these changes

2026-01-05 11:56:52 +00:00

Sign in to join this conversation.

No reviewers

thesimplekid

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cashubtc/cdk!1490

Rows
Columns