cashubtc/cdk

Fork 0

Fix: Remove test-all command from Justfile #1721

Merged

TheMhv merged 1 commit from fix/justfile into main

2026-03-12 19:17:35 +00:00

TheMhv commented

2026-03-09 21:08:43 +00:00

(Migrated from github.com)

Description

The command just test-all doesn't seem to work. This PR try to fix this calling the other tests with right arguments.

edit: Remove this command because it's heavy to be useful.

Notes to the reviewers

~~Added test-units and test-pure to test-all command~~
~~Change the default database to sqlite (memory and postgresql does not work on my machine)~~
Remove test-all command from justfile
Lint the justfile

Suggested CHANGELOG Updates

CHANGED

~~justfile test-all command~~

ADDED

REMOVED

justfile test-all command

FIXED

Checklist

I followed the code style guidelines
I ran just final-check before committing

### Description  The command `just test-all` doesn't seem to work. This PR try to fix this calling the other tests with right arguments. edit: Remove this command because it's heavy to be useful. ----- ### Notes to the reviewers  - ~~Added `test-units` and `test-pure` to `test-all` command~~ - ~~Change the default database to **sqlite** (memory and postgresql does not work on my machine)~~ - Remove `test-all` command from justfile - Lint the `justfile` ----- ### Suggested [CHANGELOG](https://github.com/cashubtc/cdk/blob/main/CHANGELOG.md) Updates  #### CHANGED - ~~`justfile` test-all command~~ #### ADDED #### REMOVED - `justfile` **test-all** command #### FIXED ---- ### Checklist * [x] I followed the [code style guidelines](https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md) * [x] I ran `just final-check` before committing

thesimplekid commented

2026-03-09 22:33:00 +00:00

(Migrated from github.com)

Honestly, I think the just test all is probably to heavy to be useful and should maybe just be removed.

TheMhv commented

2026-03-10 00:07:35 +00:00

(Migrated from github.com)

Honestly, I think the just test all is probably to heavy to be useful and should maybe just be removed.

I agree. I was using before every PR but take a lot of time. Now i just use final-check and test-pure (that take a long time too).

I will change this PR propouse to remove then

> Honestly, I think the just test all is probably to heavy to be useful and should maybe just be removed. I agree. I was using before every PR but take a lot of time. Now i just use `final-check` and `test-pure` (that take a long time too). I will change this PR propouse to remove then

thesimplekid commented

2026-03-10 08:26:33 +00:00

(Migrated from github.com)

~~I updated the PR recommendation to be run just quick-check but think you opened this before I merged that since it just says final check.~~ This should be faster then final-check, as it just runs fmt, clippy and unit tests without integrations tests. But it is still slow but thats just rust. I was thinking we could remove the unit tests from this or make it an optional flag to make it fast. A I'm not sure running all unit tests like that is generally helpful as you're re running tests is parts of the code base that you didn't change. I generally just run the specefic tests that I know cover what I'm working on but this is tougher for new contributors that don't know the code base well or test suite.

Edit: Looks like I added the quick-check command but didn't update the PR template

~~I updated the PR recommendation to be run just quick-check but think you opened this before I merged that since it just says final check.~~ This should be faster then final-check, as it just runs fmt, clippy and unit tests without integrations tests. But it is still slow but thats just rust. I was thinking we could remove the unit tests from this or make it an optional flag to make it fast. A I'm not sure running all unit tests like that is generally helpful as you're re running tests is parts of the code base that you didn't change. I generally just run the specefic tests that I know cover what I'm working on but this is tougher for new contributors that don't know the code base well or test suite. Edit: Looks like I added the quick-check command but didn't update the PR template

thesimplekid (Migrated from github.com) approved these changes

2026-03-12 19:17:29 +00:00

No reviewers

thesimplekid

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cashubtc/cdk!1721

No description provided.

Rows
Columns