when a mint PostMeltQuoteBolt11Response has amount set to 0, this mean the wallet is trying to get an amountless (zero-amount invoice) request invoice in the request a melt quote,

when this happen, we are going to check mint MeltMethodSetting if it's support for amountless bolt11

@thesimplekid

when a mint `PostMeltQuoteBolt11Response` has amount set to 0, this mean the wallet is trying to get an amountless (zero-amount invoice) request invoice in the request a melt quote, when this happen, we are going to check mint `MeltMethodSetting` if it's support for amountless bolt11 @thesimplekid

thesimplekid commented

2024-11-19 10:34:14 +00:00

(Migrated from github.com)

No, the PostMeltQuoteBolt11Request should be extend to have an optional field as in the linked nut pr of the amount in the case of an amount less invoice. If this is supported by the mint then that amount should be paid. There should also be a check that if there is also an amount in the invoice it is the same as requested. The PostMeltQuoteBolt11Response does not need to change.

No, the `PostMeltQuoteBolt11Request` should be extend to have an optional field as in the linked nut pr of the amount in the case of an amount less invoice. If this is supported by the mint then that amount should be paid. There should also be a check that if there is also an amount in the invoice it is the same as requested. The `PostMeltQuoteBolt11Response` does not need to change.

mubarak23 commented

2024-11-19 12:33:34 +00:00

(Migrated from github.com)

i understand, so if there is an option amount field set in PostMeltQuoteBolt11Request then mint should check if it's support amountless (zero-amount invoice), then ensure the amount field match what is in the request bolt11 Lightning invoice

i understand, so if there is an option amount field set in `PostMeltQuoteBolt11Request` then mint should check if it's support `amountless` (zero-amount invoice), then ensure the amount field match what is in the request bolt11 Lightning invoice

thesimplekid commented

2024-11-19 12:36:22 +00:00

(Migrated from github.com)

Yes.

then ensure the amount field match what is in the request bolt11 Lightning invoice

Only if there is amount included in the invoice.

Yes. > then ensure the amount field match what is in the request bolt11 Lightning invoice Only if there is amount included in the invoice.

👍 1

mubarak23 commented

2024-11-28 08:25:57 +00:00

(Migrated from github.com)

Yes.

then ensure the amount field match what is in the request bolt11 Lightning invoice

Only if there is amount included in the invoice.

can an invoice comes without an amount

> Yes. > > > then ensure the amount field match what is in the request bolt11 Lightning invoice > > Only if there is amount included in the invoice. can an invoice comes without an amount

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cashubtc/cdk#460

No description provided.

Rows
Columns