cashubtc/cdk

Remove `pub` properties from structs #606

New issue

Open

opened 2025-02-18 10:22:04 +00:00 by crodas · 7 comments

crodas commented

2025-02-18 10:22:04 +00:00

(Migrated from github.com)

Follow up:

Originally posted by @thesimplekid in https://github.com/cashubtc/cdk/issues/564#issuecomment-2665151917

Remove all the pub from non-payload or config entries properties. Everywhere where they could be updated with consequences outside of their logic, they should be private and exposed with a getter or a Deref trait, with their log the update hidden in the struct.

Follow up: _Originally posted by @thesimplekid in https://github.com/cashubtc/cdk/issues/564#issuecomment-2665151917_ Remove all the `pub` from non-payload or config entries properties. Everywhere where they could be updated with consequences outside of their logic, they should be private and exposed with a getter or a Deref trait, with their log the update hidden in the struct.

yashbhutwala commented

2025-09-16 20:58:17 +00:00

(Migrated from github.com)

Can this issue be closed since #782 was merged?

Can this issue be closed since #782 was merged?

github-actions[bot] commented

2025-11-16 02:57:32 +00:00

(Migrated from github.com)

This issue is stale because it has been open for 60 days with no activity.

This issue is stale because it has been open for 60 days with no activity.

thesimplekid commented

2025-11-16 12:32:22 +00:00

(Migrated from github.com)

@crodas We were just talking about this.

@crodas We were just talking about this.

crodas commented

2025-11-16 12:54:13 +00:00

(Migrated from github.com)

I will work on this issue this week

I will work on this issue this week

thesimplekid commented

2025-11-16 14:07:57 +00:00

(Migrated from github.com)

Its not top priority lets prioritize wallet tx and kv store.

Its not top priority lets prioritize wallet tx and kv store.

github-actions[bot] commented

2026-01-16 03:11:47 +00:00

(Migrated from github.com)

This issue is stale because it has been open for 60 days with no activity.

This issue is stale because it has been open for 60 days with no activity.

thesimplekid commented

2026-01-18 10:34:41 +00:00

(Migrated from github.com)

@crodas assigning you as we said we would do it as part of the wallet trait.

@crodas assigning you as we said we would do it as part of the wallet trait.

Sign in to join this conversation.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cashubtc/cdk#606

No description provided.