Remove Memory database #607

New issue

Closed

opened 2025-02-18 14:03:34 +00:00 by thesimplekid · 2 comments

thesimplekid commented

2025-02-18 14:03:34 +00:00

(Migrated from github.com)

We've discussed removing the memory database from the mint database. In cases where an in memory database is desired an in memory sql db could be used and it removed the need for us to maintain another db within cdk. I think this is fairly obvious for the mint should be also do it for the wallet?

cc @crodas

crodas commented

2025-02-18 14:12:17 +00:00

(Migrated from github.com)

I have started working on it and will submit a PR shortly. In my PR, SQLite with :memory: is being used, with migration every time the Memory Database is being created.

The main benefit would be fewer things to maintain, specially when transactions changes are added to the database, it will be implemented already by the SQLite driver.

Does this sound like a plan?

I have started working on it and will submit a PR shortly. In my PR, SQLite with `:memory:` is being used, with migration every time the Memory Database is being created. The main benefit would be fewer things to maintain, specially when transactions changes are added to the database, it will be implemented already by the SQLite driver. Does this sound like a plan?

thesimplekid commented

2025-02-18 14:14:27 +00:00

(Migrated from github.com)

Does this sound like a plan?

Yes I'm happy we do this for both mint and wallet unless, anyone thinks we should keep it?

> Does this sound like a plan? Yes I'm happy we do this for both mint and wallet unless, anyone thinks we should keep it?

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cashubtc/cdk#607

No description provided.

Rows
Columns