Read the latest mint quote status in a transaction to avoid race conditions #1166

2025-10-08T00:08:08Z

crodas commented

2025-10-08 00:08:08 +00:00

(Migrated from github.com)

Description

Fixes #1162

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Checklist

I followed the code style guidelines
I ran just final-check before committing

### Description Fixes #1162 ----- ### Notes to the reviewers  ----- ### Suggested [CHANGELOG](https://github.com/cashubtc/cdk/blob/main/CHANGELOG.md) Updates  #### CHANGED #### ADDED #### REMOVED #### FIXED ---- ### Checklist * [x] I followed the [code style guidelines](https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md) * [x] I ran `just final-check` before committing

thesimplekid (Migrated from github.com) reviewed

2025-10-08 08:31:09 +00:00

crates/cdk/src/mint/ln.rs

				`@ -45,6 +45,20 @@ impl Mint {`

I think we should do this for all payment methods? The same race condition could occur.

crodas (Migrated from github.com) reviewed

2025-10-08 10:02:16 +00:00

crates/cdk/src/mint/ln.rs

				`@ -45,6 +45,20 @@ impl Mint {`

Yes, done in a93b8c9d

Yes, done in a93b8c9d

thesimplekid (Migrated from github.com) requested changes

2025-10-08 11:48:44 +00:00

crates/cdk/src/mint/ln.rs

					
				@ -48,0 +57,4 @@

				            && (current_state == MintQuoteState::Issued || current_state == MintQuoteState::Paid)

				        {

				            return Ok(());

				        }

This needs to be only bolt11 though, since bolt12 can be paid multiple time.

crodas (Migrated from github.com) reviewed

2025-10-08 11:58:38 +00:00

crates/cdk/src/mint/ln.rs

					
				@ -48,0 +57,4 @@

				            && (current_state == MintQuoteState::Issued || current_state == MintQuoteState::Paid)

				        {

				            return Ok(());

				        }