fix: check the removed_ys argument before creating the delete query #1198

Merged
asmogo merged 1 commit from fix/wallet-remove-y into main 2025-11-12 17:08:58 +00:00
asmogo commented 2025-10-21 12:43:10 +00:00 (Migrated from github.com)

Description

Increasing PSQL compatibility.

it's not causing any error on SQLITE or CRDB.

with PSQL I was getting this error:

Error updating proofs: Database error: db error: ERROR: syntax error at or near ")"

Notes to the reviewers


Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED


Checklist

### Description Increasing PSQL compatibility. it's not causing any error on SQLITE or CRDB. with PSQL I was getting this error: ``` Error updating proofs: Database error: db error: ERROR: syntax error at or near ")" ``` <!-- Describe the purpose of this PR, what's being adding and/or fixed --> ----- ### Notes to the reviewers <!-- In this section you can include notes directed to the reviewers, like explaining why some parts of the PR were done in a specific way --> ----- ### Suggested [CHANGELOG](https://github.com/cashubtc/cdk/blob/main/CHANGELOG.md) Updates <!-- Please do not edit the actual changelog but note what you changed here. --> #### CHANGED #### ADDED #### REMOVED #### FIXED ---- ### Checklist * [ ] I followed the [code style guidelines](https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md) * [ ] I ran `just final-check` before committing
asmogo commented 2025-10-21 14:51:58 +00:00 (Migrated from github.com)

minting blind auth tokens using get_blind_auth_token works with this fix.

minting blind auth tokens using `get_blind_auth_token` works with this fix.
asmogo commented 2025-10-22 07:07:53 +00:00 (Migrated from github.com)

I will continue searching for more places where we create delete statements with empty values in this pull request.

I will continue searching for more places where we create delete statements with empty values in this pull request.
crodas (Migrated from github.com) approved these changes 2025-10-22 09:55:22 +00:00
thesimplekid (Migrated from github.com) approved these changes 2025-11-12 17:08:52 +00:00
thesimplekid (Migrated from github.com) left a comment

Sorry for the delay lost track of this one

Sorry for the delay lost track of this one
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cashubtc/cdk!1198
No description provided.