test: add mutation testing infrastructure #1210

Merged

thesimplekid merged 1 commit from mutants into main

2025-11-14 16:36:17 +00:00

thesimplekid commented

2025-10-26 02:14:39 +00:00

(Migrated from github.com)

Mutation testing validates test quality by introducing code changes and checking if tests catch them. This is critical for security code where missing negative tests could allow bypasses.

What This Adds

Infrastructure:

.cargo/mutants.toml - Configuration with timeout exclusions
justfile commands - mutants-quick, mutants-check, mutants-diff
GitHub Actions - Weekly mutation testing with issue creation

Security-Critical Tests:

NUT12 (DLEQ): 5 tests ensuring signature verification (prevents token forgery)
NUT14 (HTLC): 6 tests ensuring spending conditions (prevents unauthorized spending)
Amount operations: Tests for subtraction, checked_add, try_sum (prevents infinite loops)

Results

Mutations Caught: 301 → 308 (+7, +2.3%)
Mutations Missed: 281 → 274 (-7, -2.5%)
Mutation Coverage: 35.5% → 36.4% (+0.9%)
All critical verification functions: 100% coverage

Description

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Checklist

I followed the code style guidelines
I ran just final-check before committing

Mutation testing validates test quality by introducing code changes and checking if tests catch them. This is critical for security code where missing negative tests could allow bypasses. ## What This Adds **Infrastructure:** - `.cargo/mutants.toml` - Configuration with timeout exclusions - `justfile` commands - `mutants-quick`, `mutants-check`, `mutants-diff` - GitHub Actions - Weekly mutation testing with issue creation **Security-Critical Tests:** - NUT12 (DLEQ): 5 tests ensuring signature verification (prevents token forgery) - NUT14 (HTLC): 6 tests ensuring spending conditions (prevents unauthorized spending) - Amount operations: Tests for subtraction, checked_add, try_sum (prevents infinite loops) ## Results - Mutations Caught: 301 → 308 (+7, +2.3%) - Mutations Missed: 281 → 274 (-7, -2.5%) - Mutation Coverage: 35.5% → 36.4% (+0.9%) - All critical verification functions: 100% coverage ### Description  ----- ### Notes to the reviewers  ----- ### Suggested [CHANGELOG](https://github.com/cashubtc/cdk/blob/main/CHANGELOG.md) Updates  #### CHANGED #### ADDED #### REMOVED #### FIXED ---- ### Checklist * [ ] I followed the [code style guidelines](https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md) * [ ] I ran `just final-check` before committing

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cashubtc/cdk!1210

No description provided.

Rows
Columns