Fix websocket issues and mint quotes #1246

2025-11-02T01:38:02Z

crodas commented

2025-11-02 01:38:02 +00:00

(Migrated from github.com)

Description

When checking with HTTP pulling, mint quotes would ping the ln backend if needed to get any payment that may not be included, so the mint uses this chance to correct its database.

This check was missing for database subscriptions

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Checklist

I followed the code style guidelines
I ran just final-check before committing

### Description Fixes #1209 and #1104 When checking with HTTP pulling, mint quotes would ping the ln backend if needed to get any payment that may not be included, so the mint uses this chance to correct its database. This check was missing for database subscriptions ----- ### Notes to the reviewers  ----- ### Suggested [CHANGELOG](https://github.com/cashubtc/cdk/blob/main/CHANGELOG.md) Updates  #### CHANGED #### ADDED #### REMOVED #### FIXED ---- ### Checklist * [ ] I followed the [code style guidelines](https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md) * [ ] I ran `just final-check` before committing

thesimplekid (Migrated from github.com) reviewed

2025-11-02 22:11:09 +00:00

thesimplekid (Migrated from github.com) left a comment

Nice looks good just think one doc comment needs to be fixed.

crates/cdk/src/mint/subscription.rs

					
				@ -1,11 +1,14 @@

				//! Specific Subscription for the cdk crate

I think this comment is cut off?

crodas (Migrated from github.com) reviewed

2025-11-02 22:26:20 +00:00

crates/cdk/src/mint/subscription.rs

					
				@ -1,11 +1,14 @@

				//! Specific Subscription for the cdk crate

Yeah, that was the old doc-doc from a previous approach. Lemme update it.

thesimplekid (Migrated from github.com) approved these changes

2025-11-03 00:05:45 +00:00

cdk-bot commented

2025-11-03 00:06:42 +00:00

(Migrated from github.com)

Backport failed for v0.13.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin v0.13.x
git worktree add -d .worktree/backport-1246-to-v0.13.x origin/v0.13.x
cd .worktree/backport-1246-to-v0.13.x
git switch --create backport-1246-to-v0.13.x
git cherry-pick -x c6434b88d1498e66b3a43619612f836a2b383ada

Backport failed for `v0.13.x`, because it was unable to cherry-pick the commit(s). Please cherry-pick the changes locally and resolve any conflicts. ```bash git fetch origin v0.13.x git worktree add -d .worktree/backport-1246-to-v0.13.x origin/v0.13.x cd .worktree/backport-1246-to-v0.13.x git switch --create backport-1246-to-v0.13.x git cherry-pick -x c6434b88d1498e66b3a43619612f836a2b383ada ```

Sign in to join this conversation.

No reviewers

thesimplekid

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cashubtc/cdk!1246

				`@ -1,11 +1,14 @@`
				`//! Specific Subscription for the cdk crate`

Rows
Columns