feat: Mint reporting rpc #1487
No reviewers
Labels
No labels
DB & Storage
Deployment
Error Handling & Logging
Maintenance
Payment Backend
backport
backport v0.13.x
backport v0.14.x
backport v0.15.x
bindings
blocked
bug
cdk-sql
ci
cli
deps
documentation
duplicate
enhancement
good first issue
help wanted
invalid
keep-open
ldk-node-ui
migrations
mint
mutation-testing
needs rebase
needs review
new nut
nut change
question
ready
rust-version
rustfmt
stacked hold
stale
testing
wallet
weekly-report
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
cashubtc/cdk!1487
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "orangeshyguy21/feature/mint-data-rpc"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
This PR splits the mint gRPC API into management and reporting services.
Mint reporting endpoints are introduced to expose mint records (balances, keysets, quotes, proofs, signatures, operations).
Mint management endpoints were added (update_tos_url, create_backup).
Notes to the reviewers
There is one outstanding shortcoming with this PR
Changes are required to core traits to expose this information
Some features were not included in with this PR that are may be candidates for future improvement
There are 'breaking' changes in this PR as the current proto file was renamed and reorganized. Consumers will be required to change their implementation to support this release.
Suggested CHANGELOG Updates
CHANGED
get-infoand is now on a dedicatedget-balancesmethodADDED
tos_urltoget_infoand addedupdate_tos_urlrpc methodChecklist
just final-checkbefore committingCan we do this issue as part of this? https://github.com/cashubtc/cdk/issues/1093
Yes, this issue gets addressed in the PR.
We should split this up into multiple focused prs for better review.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.