WIP: Bindings #1706

2026-03-06T04:59:23Z

crodas commented

2026-03-06 04:59:23 +00:00

(Migrated from github.com)

Description

Prototype to have a monorepo for all the bindings

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Checklist

I followed the code style guidelines
I ran just final-check before committing

### Description Prototype to have a monorepo for all the bindings ----- ### Notes to the reviewers  ----- ### Suggested [CHANGELOG](https://github.com/cashubtc/cdk/blob/main/CHANGELOG.md) Updates  #### CHANGED #### ADDED #### REMOVED #### FIXED ---- ### Checklist * [ ] I followed the [code style guidelines](https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md) * [ ] I ran `just final-check` before committing

thesimplekid (Migrated from github.com) reviewed

2026-03-06 08:33:20 +00:00

thesimplekid (Migrated from github.com) left a comment

Nice. I think this is generally in the right direction though I didn't try to run anything.

bindings/README.md

					
				@ -0,0 +13,4 @@

				integration layers where Rust code can be adapted to the conventions and native

				capabilities of each platform or language runtime.

				[1]: https://gitlab.com/ark-bitcoin/bark-ffi-bindings

Should make this more what it is and how to use it and when we need to modify it. We can credit bark at the end of the readme.

bindings/dart/rust/Cargo.toml

					
				@ -0,0 +1,31 @@

				[package]

We should pick a tag, looks like payjoin is using v0.1.0+v0.30.0, do we need main. If so whatever commit is working for us.

bindings/dart/rust/uniffi-bindgen.rs

					
				@ -0,0 +1,126 @@

				//! Build script

Can we just add a little more detail on why we need to patch and if it might change in the future as I understand this is required but it could be fragile, so to save us some time debugging in the future. Also if we could track what we need in order to avoid patching to get the upstream that would be great.

bindings/swift/generate-bindings.sh

					
				@ -0,0 +1,254 @@

				#!/bin/bash

We need to define this in a nix and not use rustup

Should define this in a flake and not use rustup

crates/cdk-ffi/Cargo.toml

					
				@ -28,7 +28,7 @@ serde = { workspace = true, features = ["derive", "rc"] }

				serde_json = { workspace = true }

Can this be a workspace dep, we use it in multiple places?

crates/cdk-ffi/src/database.rs

					
				@ -1908,6 +1908,38 @@ pub enum WalletDbBackend {

				    },

We use the enum because of a uniffi limitation of being able to use a trait directly, I'm guessing? Can we just add a comment explaining that?

Should we add some constructors on the enum, new_sqlite(path), new_psgl(url) for example? Think that would be easier for downstream to use.

We use the enum because of a uniffi limitation of being able to use a trait directly, I'm guessing? Can we just add a comment explaining that? Should we add some constructors on the enum, new_sqlite(path), new_psgl(url) for example? Think that would be easier for downstream to use.

crodas (Migrated from github.com) reviewed

2026-03-06 14:48:15 +00:00

crates/cdk-ffi/src/database.rs

					
				@ -1908,6 +1908,38 @@ pub enum WalletDbBackend {

				    },

We use the enum because of a uniffi limitation of being able to use a trait directly, I'm guessing? Can we just add a comment explaining that?

Yeah, I'll expand on that. But that is the reason

> We use the enum because of a uniffi limitation of being able to use a trait directly, I'm guessing? Can we just add a comment explaining that? Yeah, I'll expand on that. But that is the reason

thesimplekid commented

2026-03-11 11:57:05 +00:00

(Migrated from github.com)

I notice the flake.lock is not changed after adding the dart overlay. This could be what is causing the rate limiting as this needs to be updated. nix flake lock should be run and the new lock file committed.

I notice the flake.lock is not changed after adding the dart overlay. This could be what is causing the rate limiting as this needs to be updated. `nix flake lock` should be run and the new lock file committed.

👍 1

thesimplekid (Migrated from github.com) reviewed

2026-03-11 14:28:14 +00:00

crodas (Migrated from github.com) reviewed

2026-03-11 15:15:32 +00:00

crodas (Migrated from github.com) reviewed

2026-03-11 15:16:20 +00:00

This pull request is marked as a work in progress.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin crodas/feature/bindings:crodas/feature/bindings

git switch crodas/feature/bindings

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff crodas/feature/bindings

git switch crodas/feature/bindings

git rebase main

git switch main

git merge --ff-only crodas/feature/bindings

git switch crodas/feature/bindings

git rebase main

git switch main

git merge --no-ff crodas/feature/bindings

git switch main

git merge --squash crodas/feature/bindings

git switch main

git merge --ff-only crodas/feature/bindings

git switch main

git merge crodas/feature/bindings

git push origin main

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cashubtc/cdk!1706

				`@ -28,7 +28,7 @@ serde = { workspace = true, features = ["derive", "rc"] }`
				`serde_json = { workspace = true }`

				`@ -0,0 +1,31 @@`
				`[package]`

				`@ -0,0 +1,126 @@`
				`//! Build script`

				`@ -0,0 +1,254 @@`
				`#!/bin/bash`

Rows
Columns