cashubtc/cdk

Fork 0

fix: publish pub sub after tx commit #1738

Open

thesimplekid wants to merge 1 commit from thesimplekid/publish_pub_sub into main

thesimplekid commented

2026-03-17 23:33:47 +00:00

(Migrated from github.com)

Description

Similar to https://github.com/cashubtc/cdk/pull/1511 we should only publish pubsub notifications after they are committed.

I think this is the cause of some race conditions and flakyness in the ci tests (I hope).

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Checklist

I followed the code style guidelines
I ran just final-check before committing

### Description  ----- Similar to https://github.com/cashubtc/cdk/pull/1511 we should only publish pubsub notifications after they are committed. I think this is the cause of some race conditions and flakyness in the ci tests (I hope). ### Notes to the reviewers  ----- ### Suggested [CHANGELOG](https://github.com/cashubtc/cdk/blob/main/CHANGELOG.md) Updates  #### CHANGED #### ADDED #### REMOVED #### FIXED ---- ### Checklist * [ ] I followed the [code style guidelines](https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md) * [ ] I ran `just final-check` before committing

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin thesimplekid/publish_pub_sub:thesimplekid/publish_pub_sub

git switch thesimplekid/publish_pub_sub

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff thesimplekid/publish_pub_sub

git switch thesimplekid/publish_pub_sub

git rebase main

git switch main

git merge --ff-only thesimplekid/publish_pub_sub

git switch thesimplekid/publish_pub_sub

git rebase main

git switch main

git merge --no-ff thesimplekid/publish_pub_sub

git switch main

git merge --squash thesimplekid/publish_pub_sub

git switch main

git merge --ff-only thesimplekid/publish_pub_sub

git switch main

git merge thesimplekid/publish_pub_sub

git push origin main

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cashubtc/cdk!1738

No description provided.

Rows
Columns