feat: nut-20 signature on mint witness #446

2024-11-08T19:59:03Z

thesimplekid commented

2024-11-08 19:59:03 +00:00

(Migrated from github.com)

https://github.com/cashubtc/nuts/pull/188

callebtc (Migrated from github.com) reviewed

2024-12-14 00:18:53 +00:00

crates/cdk-integration-tests/tests/fake_wallet.rs

					
				@ -376,6 +376,105 @@ async fn test_fake_melt_change_in_quote() -> Result<()> {

				    Ok(())

				}

Would it be good to generate secret inside wallet.mint_quote and also put it into the database there, so when you call wallet.mint() a few lines further, you don't need to provide secret.public_key() but could fetch it from the db again inside wallet.mint()?

Would it be good to generate `secret` inside `wallet.mint_quote` and also put it into the database there, so when you call `wallet.mint()` a few lines further, you don't need to provide `secret.public_key()` but could fetch it from the db again inside `wallet.mint()`?

thesimplekid (Migrated from github.com) reviewed

2024-12-14 18:03:07 +00:00

crates/cdk-integration-tests/tests/fake_wallet.rs

					
				@ -376,6 +376,105 @@ async fn test_fake_melt_change_in_quote() -> Result<()> {

				    Ok(())

				}

Yeah I was thinking about this I initially did it this way to avoid storing the secret in the database but I don't think there is much benefit to that. Storing it in the cdk database makes it much easier for the implementer as they do not have to store or manage secrets so I will go this route as you suggest.

thesimplekid (Migrated from github.com) reviewed

2024-12-16 18:16:44 +00:00

crates/cdk-integration-tests/tests/fake_wallet.rs

					
				@ -376,6 +376,105 @@ async fn test_fake_melt_change_in_quote() -> Result<()> {

				    Ok(())

				}

addressed by 4051e493482bb385708bd3fbe42536f659d3c936

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cashubtc/cdk!446

Rows
Columns