feat: payment processor #597

2025-02-11T13:37:33Z

thesimplekid commented

2025-02-11 13:37:33 +00:00

(Migrated from github.com)

Description

Remove strike and phd from readme

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Checklist

I followed the code style guidelines
I ran just final-check before committing

### Description  ----- - [x] Remove strike and phd from readme ### Notes to the reviewers  ----- ### Suggested [CHANGELOG](https://github.com/cashubtc/cdk/blob/main/CHANGELOG.md) Updates  #### CHANGED #### ADDED #### REMOVED #### FIXED ---- ### Checklist * [x] I followed the [code style guidelines](https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md) * [x] I ran `just final-check` before committing

crodas (Migrated from github.com) reviewed

2025-02-11 13:37:33 +00:00

ok300 (Migrated from github.com) reviewed

2025-02-24 16:20:35 +00:00

crates/cdk-common/src/error.rs

					
				@ -265,3 +265,3 @@

				    #[error(transparent)]

				    Database(#[from] crate::database::Error),

				    /// Lightning Error

				    /// Payment Error

    /// Payment Error

```suggestion /// Payment Error ```

crates/cdk-mintd/src/main.rs

unwrap() -> ?

`unwrap()` -> `?`

crates/cdk-payment-processor/build.rs

					
				@ -0,0 +1,5 @@

				fn main() -> Result<(), Box<dyn std::error::Error>> {

    println!("cargo:rerun-if-changed=src/proto/payment_processor.proto");

```suggestion println!("cargo:rerun-if-changed=src/proto/payment_processor.proto"); ```

crates/cdk-payment-processor/src/proto/client.rs

					
				@ -0,0 +1,299 @@

				use std::path::PathBuf;

unwrap() should be replaced with ?

`unwrap()` should be replaced with `?`

crates/cdk-payment-processor/src/proto/server.rs

					
				@ -0,0 +1,345 @@

				use std::net::SocketAddr;

unwrap() -> ?

`unwrap()` -> `?`

codingpeanut157 (Migrated from github.com) reviewed

2025-02-27 17:00:13 +00:00

crates/cdk-payment-processor/src/proto/payment_processor.proto

					
				@ -0,0 +1,113 @@

				syntax = "proto3";

\n missing

`\n` missing

davidcaseria (Migrated from github.com) reviewed

2025-03-01 12:33:30 +00:00

crates/cdk/src/mint/builder.rs

					
				@ -27,7 +29,9 @@ pub struct MintBuilder {

				    /// Mint Storage backend

Do you plan to make this more generic with on-chain?

thesimplekid (Migrated from github.com) reviewed

2025-03-02 08:33:45 +00:00

crates/cdk/src/mint/builder.rs

					
				@ -27,7 +29,9 @@ pub struct MintBuilder {

				    /// Mint Storage backend

Yes, the plan is to use this trait for all payment backends. If we looks at the ones I created for bolt12 and onchain. I think we can use what we have here without modify it but there would be some unused fields. The problem as I see it is to make it really general for everything we could just use Value but this loses typing so Ideally we don't do this though I did use it for the settings endpoint. But if we try to create types now to make it more general for things we dont support yet (onchain, bolt11) we may need to end up chaining them later anyway. So I think its best to keep the grpc api pretty close to what we know we need and currently support, bolt11, and then make changes when we know we need them and what changes we need to support bolt12, and onchain or whatever else.

That being said I'm certainly open if you have suggestions to the api at this point as I mostly just reused what we had in the previous trait.

Yes, the plan is to use this trait for all payment backends. If we looks at the ones I created for [bolt12](https://github.com/cashubtc/cdk/blob/cc4a63bd2bdd7c9b1bd592bb4f1c9bd03d6c9d3f/crates/cdk/src/cdk_lightning/bolt12.rs#L17) and [onchain](https://github.com/cashubtc/cdk/blob/8dc537a18ea3a30b7d24c7f69d7d1de006b0111a/crates/cdk/src/cdk_onchain/mod.rs#L33). I think we can use what we have here without modify it but there would be some unused fields. The problem as I see it is to make it really general for everything we could just use `Value` but this loses typing so Ideally we don't do this though I did use it for the settings endpoint. But if we try to create types now to make it more general for things we dont support yet (onchain, bolt11) we may need to end up chaining them later anyway. So I think its best to keep the grpc api pretty close to what we know we need and currently support, bolt11, and then make changes when we know we need them and what changes we need to support bolt12, and onchain or whatever else. That being said I'm certainly open if you have suggestions to the api at this point as I mostly just reused what we had in the previous trait.

davidcaseria (Migrated from github.com) reviewed

2025-03-03 15:18:07 +00:00

crates/cdk/src/mint/builder.rs

					
				@ -27,7 +29,9 @@ pub struct MintBuilder {

				    /// Mint Storage backend

The trait is well-defined. Should the LnKey struct be made more generic now or later?

The trait is well-defined. Should the `LnKey` struct be made more generic now or later?

thesimplekid (Migrated from github.com) reviewed

2025-03-04 08:54:54 +00:00

crates/cdk/src/mint/builder.rs

					
				@ -27,7 +29,9 @@ pub struct MintBuilder {

				    /// Mint Storage backend

Should the LnKey struct be made more generic now or later?

Good catch f46d84e631148bd4ebe5c8343c63ee405f8913e0

> Should the LnKey struct be made more generic now or later? Good catch f46d84e631148bd4ebe5c8343c63ee405f8913e0

ok300 (Migrated from github.com) approved these changes

2025-03-10 10:03:14 +00:00

ok300 (Migrated from github.com) left a comment

Had another look at it, looks good.

Sign in to join this conversation.

No reviewers

crodas

ok300

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cashubtc/cdk!597

				`@ -0,0 +1,5 @@`
				`fn main() -> Result<(), Box<dyn std::error::Error>> {`

				`@ -27,7 +29,9 @@ pub struct MintBuilder {`
				`/// Mint Storage backend`

Rows
Columns