Drop AmountStr #612

2025-02-21T23:04:30Z

crodas commented

2025-02-21 23:04:30 +00:00

(Migrated from github.com)

Description

Fixes #609

Instead write a customer serializer for Keys to serialize amounts as strings

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Checklist

I followed the code style guidelines
I ran just final-check before committing

### Description Fixes #609 Instead write a customer serializer for Keys to serialize amounts as strings ----- ### Notes to the reviewers  ----- ### Suggested [CHANGELOG](https://github.com/cashubtc/cdk/blob/main/CHANGELOG.md) Updates  #### CHANGED #### ADDED #### REMOVED #### FIXED ---- ### Checklist * [x] I followed the [code style guidelines](https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md) * [x] I ran `just final-check` before committing

ok300 (Migrated from github.com) reviewed

2025-02-22 08:07:01 +00:00

ok300 (Migrated from github.com) left a comment

Found a NIT for error type, otherwise looks good.

crates/cashu/src/amount.rs

					
				@ -26,3 +28,4 @@

				    InvalidAmount(String),

				}

				/// Amount can be any unit

Parsing "1.23" will fail, but not because of overflow.

Maybe a more generic parsing error is better instead of Error::AmountOverflow?

Parsing "1.23" will fail, but not because of overflow. Maybe a more generic parsing error is better instead of `Error::AmountOverflow`?

crodas (Migrated from github.com) reviewed

2025-02-22 12:50:02 +00:00

crates/cashu/src/amount.rs

					
				@ -26,3 +28,4 @@

				    InvalidAmount(String),

				}

				/// Amount can be any unit

Great feedback, is it any better now (f1c69fe5da) @ok300 ?

Great feedback, is it any better now (f1c69fe5da3421f91a4c046709fb900e25564ac3) @ok300 ?

thesimplekid (Migrated from github.com) approved these changes

2025-02-22 15:19:45 +00:00

thesimplekid commented

2025-02-22 15:20:01 +00:00

(Migrated from github.com)

ACK 040259c131

ACK 040259c131626cf0188326e8979b0da05749d6bc

ok300 (Migrated from github.com) reviewed

2025-02-22 17:23:11 +00:00

crates/cashu/src/amount.rs

					
				@ -26,3 +28,4 @@

				    InvalidAmount(String),

				}

				/// Amount can be any unit

Yes, looking good!

ok300 (Migrated from github.com) approved these changes

2025-02-22 17:23:21 +00:00

Sign in to join this conversation.

No reviewers

thesimplekid

ok300

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cashubtc/cdk!612

Rows
Columns