chore: Update rust-version to 1.75.0 in Cargo.toml files #623

2025-03-04T10:27:28Z

thesimplekid commented

2025-03-04 10:27:28 +00:00

(Migrated from github.com)

Description

This PR bumps the MSRV to 1.75, previously this was 1.63 (the rust version of Debian stable), while being able to support the target of Debian stable at this point it is very old and forces use to use older deps especially for gRPC related dependencies this means we may not get the newest security updates and requires many deps to be pinned. BDK has bumped the msrv of their electrum crate for these reason as well as ldk-node, while I've previously said we should try to keep 1.63 causing us all headaches (sorry), with these projects bumping I think it makes sense for us to as well.

https://github.com/bitcoindevkit/bdk/issues/1750

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Checklist

I followed the code style guidelines
I ran just final-check before committing

### Description  ----- This PR bumps the MSRV to 1.75, previously this was 1.63 (the rust version of Debian stable), while being able to support the target of Debian stable at this point it is very old and forces use to use older deps especially for gRPC related dependencies this means we may not get the newest security updates and requires many deps to be pinned. BDK has bumped the msrv of their electrum crate for these reason as well as ldk-node, while I've previously said we should try to keep 1.63 causing us all headaches (sorry), with these projects bumping I think it makes sense for us to as well. https://github.com/bitcoindevkit/bdk/issues/1750 ### Notes to the reviewers  ----- ### Suggested [CHANGELOG](https://github.com/cashubtc/cdk/blob/main/CHANGELOG.md) Updates  #### CHANGED #### ADDED #### REMOVED #### FIXED ---- ### Checklist * [x] I followed the [code style guidelines](https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md) * [x] I ran `just final-check` before committing

ok300 (Migrated from github.com) approved these changes

2025-03-04 13:05:16 +00:00

crodas (Migrated from github.com) approved these changes

2025-03-04 13:05:57 +00:00

thesimplekid commented

2025-03-04 22:55:12 +00:00

(Migrated from github.com)

Since our msrv now supports workspace inheritance I've moved all out common deps to the workspace making it easier to ensure we don't have multiple versions. Also updates deps that were stuck on older version to to msrv ie axum tonic, swagger.

ok300 (Migrated from github.com) reviewed

2025-03-05 05:01:49 +00:00

.github/workflows/ci.yml

					
				@ -260,4 +241,2 @@

				        run: nix develop -i -L .#db_shell --command cargo build ${{ matrix.build-args }}

				  check-wasm:

				    name: Check WASM

Is cdk-redb missing?

Is `cdk-redb` missing?

thesimplekid (Migrated from github.com) reviewed

2025-03-05 09:49:10 +00:00

.github/workflows/ci.yml

					
				@ -260,4 +241,2 @@

				        run: nix develop -i -L .#db_shell --command cargo build ${{ matrix.build-args }}

				  check-wasm:

				    name: Check WASM

I don't think we should commit to an MSRV with redb its too new of a project and their msrv is higher then ours and we don't want to be missing updates by pinning to an older version. In https://github.com/cashubtc/cdk/pull/623/commits/53d43b9300473a0550ddfe9c0c5265997385f6f4 I've matched the rust-version of cdk-redb to that of redb (1.81) and then added a feature to cdk-mintd so that without redb enabled it is an msrv of 1.75 and with the feature we don't commit to one.

What do you think?

I don't think we should commit to an MSRV with redb its too new of a project and their msrv is higher then ours and we don't want to be missing updates by pinning to an older version. In https://github.com/cashubtc/cdk/pull/623/commits/53d43b9300473a0550ddfe9c0c5265997385f6f4 I've matched the rust-version of cdk-redb to that of redb (1.81) and then added a feature to cdk-mintd so that without redb enabled it is an msrv of 1.75 and with the feature we don't commit to one. What do you think?

ok300 (Migrated from github.com) reviewed

2025-03-05 10:19:06 +00:00

.github/workflows/ci.yml

					
				@ -260,4 +241,2 @@

				        run: nix develop -i -L .#db_shell --command cargo build ${{ matrix.build-args }}

				  check-wasm:

				    name: Check WASM

Good point, treating it separately with a mint feature flag makes sense.

ok300 (Migrated from github.com) approved these changes

2025-03-05 10:19:17 +00:00

Sign in to join this conversation.

No reviewers

crodas

ok300

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cashubtc/cdk!623

Rows
Columns