feat: log to file #967

2025-08-15T13:53:06Z

thesimplekid commented

2025-08-15 13:53:06 +00:00

(Migrated from github.com)

Description

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Checklist

I followed the code style guidelines
I ran just final-check before committing

### Description  ----- ### Notes to the reviewers  ----- ### Suggested [CHANGELOG](https://github.com/cashubtc/cdk/blob/main/CHANGELOG.md) Updates  #### CHANGED #### ADDED #### REMOVED #### FIXED ---- ### Checklist * [ ] I followed the [code style guidelines](https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md) * [ ] I ran `just final-check` before committing

crodas (Migrated from github.com) reviewed

2025-08-15 13:53:06 +00:00

asmogo (Migrated from github.com) requested changes

2025-08-15 17:39:07 +00:00

crates/cdk-mintd/src/lib.rs

					
				@ -705,7 +804,7 @@ async fn start_services_with_shutdown(

				            tracing::info!("Mint info already set, not using config file settings.");

				        }

				    } else {

pub async fn run_mintd(

This got me confused. I would prefer calling the function run_mintd with enable_logging as an arg, or remove the arg / else statement.

```suggestion pub async fn run_mintd( ``` This got me confused. I would prefer calling the function `run_mintd` with `enable_logging` as an arg, or remove the arg / else statement.

thesimplekid (Migrated from github.com) reviewed

2025-08-16 09:42:55 +00:00

crates/cdk-mintd/src/lib.rs

					
				@ -705,7 +804,7 @@ async fn start_services_with_shutdown(

				            tracing::info!("Mint info already set, not using config file settings.");

				        }

				    } else {

Yeah thats better applied in https://github.com/cashubtc/cdk/pull/967/commits/3cd4669e5a03a241baeb200382c4b9810f80b930

Sign in to join this conversation.

No reviewers

crodas

asmogo

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cashubtc/cdk!967

Rows
Columns