Http retry should only happen at Http Error (which are transport errors) #975

2025-08-18T14:52:31Z

crodas commented

2025-08-18 14:52:31 +00:00

(Migrated from github.com)

Description

Fixes #939

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Checklist

I followed the code style guidelines
I ran just final-check before committing

### Description Fixes #939 ----- ### Notes to the reviewers  ----- ### Suggested [CHANGELOG](https://github.com/cashubtc/cdk/blob/main/CHANGELOG.md) Updates  #### CHANGED #### ADDED #### REMOVED #### FIXED ---- ### Checklist * [ ] I followed the [code style guidelines](https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md) * [ ] I ran `just final-check` before committing

thesimplekid (Migrated from github.com) requested changes

2025-08-18 15:17:19 +00:00

crates/cdk/src/wallet/mint_connector/http_client.rs

					
				@ -249,7 +268,13 @@ impl HttpClient {

				            }

                    if status_code >= 400 && status_code <= 499 {

```suggestion if status_code >= 400 && status_code <= 499 { ```

thesimplekid (Migrated from github.com) approved these changes

2025-08-18 16:38:14 +00:00

thesimplekid (Migrated from github.com) approved these changes

2025-08-19 13:56:26 +00:00

Sign in to join this conversation.

No reviewers

thesimplekid

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cashubtc/cdk!975

Rows
Columns