fix: lnbits payment check and units #981

2025-08-20T12:28:26Z

thesimplekid commented

2025-08-20 12:28:26 +00:00

(Migrated from github.com)

Description

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Checklist

I followed the code style guidelines
I ran just final-check before committing

--------- ### Description  ----- ### Notes to the reviewers  ----- ### Suggested [CHANGELOG](https://github.com/cashubtc/cdk/blob/main/CHANGELOG.md) Updates  #### CHANGED #### ADDED #### REMOVED #### FIXED ---- ### Checklist * [ ] I followed the [code style guidelines](https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md) * [ ] I ran `just final-check` before committing

asmogo (Migrated from github.com) reviewed

2025-08-20 12:28:26 +00:00

thesimplekid (Migrated from github.com) reviewed

2025-08-20 12:30:47 +00:00

crates/cdk-lnbits/src/lib.rs

					
				@ -352,12 +355,21 @@ impl MintPayment for LNbits {

				                Self::Err::Anyhow(anyhow!("Could not check invoice status"))

Should we just return an empty list here?

asmogo (Migrated from github.com) reviewed

2025-08-20 12:36:43 +00:00

crates/cdk-lnbits/src/lib.rs

					
				@ -352,12 +355,21 @@ impl MintPayment for LNbits {

				                Self::Err::Anyhow(anyhow!("Could not check invoice status"))

This would allow removing the additional ZERO check

This would allow removing the additional [ZERO check](https://github.com/cashubtc/cdk/pull/981/files#diff-3f34620819b76e5d79a77f6133983f0b0afe923226d9bf8b81d135647da77412R50)

thesimplekid (Migrated from github.com) reviewed

2025-08-20 12:55:20 +00:00

crates/cdk-lnbits/src/lib.rs

					
				@ -352,12 +355,21 @@ impl MintPayment for LNbits {

				                Self::Err::Anyhow(anyhow!("Could not check invoice status"))

Yeah looking at cln unpaid are filtered out so think its best to do the same here.

Sign in to join this conversation.

No reviewers

asmogo

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cashubtc/cdk!981

				`@ -352,12 +355,21 @@ impl MintPayment for LNbits {`
				`Self::Err::Anyhow(anyhow!("Could not check invoice status"))`

Rows
Columns