refactor: replace proof swap with state check in error recovery #1256

2025-11-06T02:39:10Z

crodas commented

2025-11-06 02:39:10 +00:00

(Migrated from github.com)

Description

This commit improves the proof recovery mechanism by replacing the swap operation with a more efficient state check approach when recovering from failed operations.

Fixes #1255

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Checklist

I followed the code style guidelines
I ran just final-check before committing

### Description This commit improves the proof recovery mechanism by replacing the swap operation with a more efficient state check approach when recovering from failed operations. Fixes #1255 ----- ### Notes to the reviewers  ----- ### Suggested [CHANGELOG](https://github.com/cashubtc/cdk/blob/main/CHANGELOG.md) Updates  #### CHANGED #### ADDED #### REMOVED #### FIXED ---- ### Checklist * [ ] I followed the [code style guidelines](https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md) * [ ] I ran `just final-check` before committing

callebtc (Migrated from github.com) reviewed

2025-11-06 02:39:10 +00:00

a1denvalu3 (Migrated from github.com) reviewed

2025-11-06 02:39:10 +00:00

a1denvalu3 (Migrated from github.com) reviewed

2025-11-06 17:07:43 +00:00

crates/cdk/src/wallet/reclaim.rs

					
				@ -30,9 +34,42 @@ impl<T: ?Sized> MaybeSend for T {}

				const BATCH_PROOF_SIZE: usize = 100;

Why are we removing the transaction

crates/cdk/src/wallet/reclaim.rs

                        "Http operation failed with \"{}\", reverting  {} proofs states to UNSPENT",

```suggestion "Http operation failed with \"{}\", reverting {} proofs states to UNSPENT", ```

crodas (Migrated from github.com) reviewed

2025-11-06 20:21:54 +00:00

crates/cdk/src/wallet/reclaim.rs

					
				@ -30,9 +34,42 @@ impl<T: ?Sized> MaybeSend for T {}

				const BATCH_PROOF_SIZE: usize = 100;

This is a standard practice that I copied from other places, @thesimplekid. I'm fine with dropping this line. Wdyt?

thesimplekid (Migrated from github.com) reviewed

2025-11-07 02:54:40 +00:00

crates/cdk/src/wallet/reclaim.rs

					
				@ -30,9 +34,42 @@ impl<T: ?Sized> MaybeSend for T {}

				const BATCH_PROOF_SIZE: usize = 100;

Where else do we remove it? My intuition is that we shouldn't have to remove it and it should never be added if the tx fails. Since I don't believe we have a failed tx state and we only add successful ones.

crates/cdk/src/wallet/reclaim.rs