cashubtc/cdk
1
0
Fork 0
Code Issues 25 Pull requests 23 Projects Releases 43 Packages Wiki Activity Actions

Melt to amountless invoice #497

Merged
thesimplekid merged 3 commits from amountless into main 2025-04-04 12:16:27 +00:00
Conversation 3 Commits 3 Files changed 16 +161 -28
thesimplekid commented 2024-12-09 17:34:25 +00:00 (Migrated from github.com)
Copy link

Description

https://github.com/cashubtc/nuts/pull/173
closes #460

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Checklist

### Description <!-- Describe the purpose of this PR, what's being adding and/or fixed --> ----- https://github.com/cashubtc/nuts/pull/173 closes #460 ### Notes to the reviewers <!-- In this section you can include notes directed to the reviewers, like explaining why some parts of the PR were done in a specific way --> ----- ### Suggested [CHANGELOG](https://github.com/cashubtc/cdk/blob/main/CHANGELOG.md) Updates <!-- Please do not edit the actual changelog but note what you changed here. --> #### CHANGED #### ADDED #### REMOVED #### FIXED ---- ### Checklist * [x] I followed the [code style guidelines](https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md) * [x] I ran `just final-check` before committing
mubarak23 (Migrated from github.com) reviewed 2024-12-10 11:30:02 +00:00
crates/cdk-cln/src/lib.rs
mubarak23 (Migrated from github.com) commented 2024-12-10 11:30:01 +00:00
Copy link

why are not using to_unit and also does this mean by default we melt_quote_request.amount()? unit is CurrencyUnit::Msat

why are not using `to_unit` and also does this mean by default we `melt_quote_request.amount()?` unit is `CurrencyUnit::Msat`
thesimplekid (Migrated from github.com) reviewed 2024-12-10 12:02:22 +00:00
crates/cdk-cln/src/lib.rs
thesimplekid (Migrated from github.com) commented 2024-12-10 12:02:22 +00:00
Copy link

github.com/cashubtc/nuts@1a976ca0be/05.md (L35)

https://github.com/cashubtc/nuts/blob/1a976ca0bef76ad2a4955128b49e023ab44dde77/05.md?plain=1#L35
thesimplekid (Migrated from github.com) reviewed 2025-01-05 13:54:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
DB & Storage

   
Deployment

   
Error Handling & Logging

   
Maintenance

   
Payment Backend

   
backport

   
backport v0.13.x

   
backport v0.14.x

   
backport v0.15.x

   
bindings

   
blocked

   
bug

Something isn't working

  
cdk-sql

   
ci

   
cli

   
deps

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
keep-open

   
ldk-node-ui

   
migrations

   
mint

   
mutation-testing

   
needs rebase

   
needs review

   
new nut

This PR is held pending the merge of a new or updated NUT

  
nut change

   
question

Further information is requested

  
ready

   
rust-version

   
rustfmt

   
stacked hold

PR is based on top of another PR, so should be merged in sequence. See comments for details.

  
stale

   
testing

   
wallet

   
weekly-report

   
wontfix

This will not be worked on

No labels
DB & Storage
Deployment
Error Handling & Logging
Maintenance
Payment Backend
backport
backport v0.13.x
backport v0.14.x
backport v0.15.x
bindings
blocked
bug
cdk-sql
ci
cli
deps
documentation
duplicate
enhancement
good first issue
help wanted
invalid
keep-open
ldk-node-ui
migrations
mint
mutation-testing
needs rebase
needs review
new nut
nut change
question
ready
rust-version
rustfmt
stacked hold
stale
testing
wallet
weekly-report
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cashubtc/cdk!497
No description provided.